peter/siftlode
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge bug/messaging-stale-thread-on-account-switch

Browse source 
Fix: switching accounts no longer lands the new user on a stale chat thread inherited
from the previous account (an empty self-thread where new messages never appeared).
Clear _sub/_ov from history.state before the switch reload + guard partnerId===meId.
User-confirmed on localdev with two real accounts.
This commit is contained in:
npeter83 2026-06-29 00:52:52 +02:00
commit 16669dba5c
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
frontend/src/components/Messages.tsx
View file

@ -22,7 +22,9 @@ export default function Messages({ meId }: { meId: number }) {
// the module (open() pushes an entry; back() = history.back()).
const { view, open, back } = useHistorySubview<View>("list");
if (typeof view === "object") {
// Guard against a stale sub-view whose partnerId is the current user's own id (you can't
// message yourself). This can be inherited across an account switch — fall back to the list.
if (typeof view === "object" && view.partnerId !== meId) {
return (
<PageThread
meId={meId}

8
frontend/src/components/NavSidebar.tsx
View file

@ -112,6 +112,14 @@ export default function NavSidebar({
async function switchTo(id: number) {
try {
await api.switchAccount(id);
// Drop the previous account's in-module sub-view/overlay before the reload (which would
// otherwise preserve history.state across the swap). Otherwise the new account lands on a
// stale sub-view — e.g. an open chat thread whose partnerId belongs to the OLD identity
// (often the new account's own id → an empty self-thread). Start at the module root instead.
const st = { ...(window.history.state || {}) };
delete st._sub;
delete st._ov;
window.history.replaceState(st, "");
location.reload(); // cleanest way to reload all per-user state for the new account
} catch {
/* a revoked/removed account — leave the popover open */