refactor(banner): extract reusable Banner base for VersionBanner + DemoBanner
Both top-of-app bars shared the same shell (icon + content + border-b bar); factor it into a tone-driven Banner with optional action/dismiss. The version/demo logic stays in the wrappers. Leaves a clean extension point for a future news-ticker variant.
This commit is contained in:
parent
a5de874dd3
commit
479574b726
3 changed files with 73 additions and 26 deletions
53
frontend/src/components/Banner.tsx
Normal file
53
frontend/src/components/Banner.tsx
Normal file
|
|
@ -0,0 +1,53 @@
|
||||||
|
import type { ReactNode } from "react";
|
||||||
|
import type { LucideIcon } from "lucide-react";
|
||||||
|
import { X } from "lucide-react";
|
||||||
|
|
||||||
|
type BannerTone = "accent" | "warning";
|
||||||
|
|
||||||
|
const TONES: Record<BannerTone, { bar: string; icon: string; action: string }> = {
|
||||||
|
accent: { bar: "bg-accent/15 border-accent/30", icon: "text-accent", action: "bg-accent text-accent-fg" },
|
||||||
|
warning: { bar: "bg-amber-500/15 border-amber-500/30", icon: "text-amber-500", action: "bg-amber-500 text-black" },
|
||||||
|
};
|
||||||
|
|
||||||
|
// Shared top-of-app notification bar. VersionBanner and DemoBanner are thin wrappers over this;
|
||||||
|
// a future news-ticker variant can build on the same shell (rotating content as children).
|
||||||
|
export default function Banner({
|
||||||
|
tone,
|
||||||
|
icon: Icon,
|
||||||
|
children,
|
||||||
|
action,
|
||||||
|
onDismiss,
|
||||||
|
dismissTitle,
|
||||||
|
}: {
|
||||||
|
tone: BannerTone;
|
||||||
|
icon: LucideIcon;
|
||||||
|
children: ReactNode;
|
||||||
|
action?: { label: string; onClick: () => void };
|
||||||
|
onDismiss?: () => void;
|
||||||
|
dismissTitle?: string;
|
||||||
|
}) {
|
||||||
|
const c = TONES[tone];
|
||||||
|
return (
|
||||||
|
<div className={`shrink-0 flex items-center gap-2 px-4 py-2 text-sm border-b text-fg ${c.bar}`}>
|
||||||
|
<Icon className={`w-4 h-4 shrink-0 ${c.icon}`} />
|
||||||
|
<span className="min-w-0">{children}</span>
|
||||||
|
{action && (
|
||||||
|
<button
|
||||||
|
onClick={action.onClick}
|
||||||
|
className={`ml-1 px-2.5 py-1 rounded-lg font-semibold hover:opacity-90 transition ${c.action}`}
|
||||||
|
>
|
||||||
|
{action.label}
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
{onDismiss && (
|
||||||
|
<button
|
||||||
|
onClick={onDismiss}
|
||||||
|
title={dismissTitle}
|
||||||
|
className="ml-auto p-1 rounded-md text-muted hover:text-fg hover:bg-card transition"
|
||||||
|
>
|
||||||
|
<X className="w-4 h-4" />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
@ -1,17 +1,15 @@
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import { AlertTriangle } from "lucide-react";
|
import { AlertTriangle } from "lucide-react";
|
||||||
|
import Banner from "./Banner";
|
||||||
|
|
||||||
// Permanent, non-dismissible bar shown to the shared demo account so it's always clear the
|
// Permanent, non-dismissible bar shown to the shared demo account so it's always clear the
|
||||||
// state is communal. (Replaces the old login-time toast, which re-popped on every reload.)
|
// state is communal. (Replaces the old login-time toast, which re-popped on every reload.)
|
||||||
export default function DemoBanner() {
|
export default function DemoBanner() {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
return (
|
return (
|
||||||
<div className="shrink-0 flex items-center gap-2 px-4 py-2 text-sm bg-amber-500/15 border-b border-amber-500/30 text-fg">
|
<Banner tone="warning" icon={AlertTriangle}>
|
||||||
<AlertTriangle className="w-4 h-4 text-amber-500 shrink-0" />
|
<span className="font-semibold">{t("common.demoTitle")}</span>
|
||||||
<span className="min-w-0">
|
<span className="text-muted"> — {t("common.demoSharedNotice")}</span>
|
||||||
<span className="font-semibold">{t("common.demoTitle")}</span>
|
</Banner>
|
||||||
<span className="text-muted"> — {t("common.demoSharedNotice")}</span>
|
|
||||||
</span>
|
|
||||||
</div>
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -1,7 +1,8 @@
|
||||||
import { useState } from "react";
|
import { useState } from "react";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import { Sparkles, X } from "lucide-react";
|
import { Sparkles } from "lucide-react";
|
||||||
import { FRONTEND_VERSION, SEEN_VERSION_KEY } from "../lib/version";
|
import { FRONTEND_VERSION, SEEN_VERSION_KEY } from "../lib/version";
|
||||||
|
import Banner from "./Banner";
|
||||||
|
|
||||||
// Eye-catching, dismissible bar shown once after the running build's version changes
|
// Eye-catching, dismissible bar shown once after the running build's version changes
|
||||||
// (compares the baked frontend version to the last one the user acknowledged).
|
// (compares the baked frontend version to the last one the user acknowledged).
|
||||||
|
|
@ -19,25 +20,20 @@ export default function VersionBanner({ onOpen }: { onOpen: () => void }) {
|
||||||
}
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="shrink-0 flex items-center gap-2 px-4 py-2 text-sm bg-accent/15 border-b border-accent/30 text-fg">
|
<Banner
|
||||||
<Sparkles className="w-4 h-4 text-accent shrink-0" />
|
tone="accent"
|
||||||
<span className="min-w-0">{t("header.banner.updated", { version: FRONTEND_VERSION })}</span>
|
icon={Sparkles}
|
||||||
<button
|
action={{
|
||||||
onClick={() => {
|
label: t("header.banner.releaseNotes"),
|
||||||
|
onClick: () => {
|
||||||
onOpen();
|
onOpen();
|
||||||
markSeen();
|
markSeen();
|
||||||
}}
|
},
|
||||||
className="ml-1 px-2.5 py-1 rounded-lg font-semibold bg-accent text-accent-fg hover:opacity-90 transition"
|
}}
|
||||||
>
|
onDismiss={markSeen}
|
||||||
{t("header.banner.releaseNotes")}
|
dismissTitle={t("header.banner.dismiss")}
|
||||||
</button>
|
>
|
||||||
<button
|
{t("header.banner.updated", { version: FRONTEND_VERSION })}
|
||||||
onClick={markSeen}
|
</Banner>
|
||||||
title={t("header.banner.dismiss")}
|
|
||||||
className="ml-auto p-1 rounded-md text-muted hover:text-fg hover:bg-card transition"
|
|
||||||
>
|
|
||||||
<X className="w-4 h-4" />
|
|
||||||
</button>
|
|
||||||
</div>
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue